Automatically set novalidate on closest form #37
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haacked
requested changes
Apr 5, 2023
There was a problem hiding this comment.
Thanks for submitting a PR! I think the code you submitted is a good start, but can probably be simplified by relying on the result of scan.
I think we may want to make options a property of this so w we don't need to pass addNoValidate all the way through. It seems silly that every option we add will have to be passed through.
haacked
reviewed
Apr 5, 2023
|
Closing as #68 includes this. |
|
Shipped as a service option in https://github.com/haacked/aspnet-client-validation/releases/tag/v0.9.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A relatively naive fix, but I think it should work 🤔 Need to update the defs etc, but wasn't sure how much of that happens in CI etc
Also, I don't have node installed, so yolo'd this before I head to bed - I'll follow up if/when it needs more work 😅
Fixes #35